PracHub
QuestionsPremiumCoachesLearningGuidesInterview Prep
|Home/Software Engineering Fundamentals/Salesforce

How do you perform a thorough code review?

Last updated: Mar 29, 2026

Quick Overview

This task evaluates a candidate's code-review proficiency across security, correctness, data modeling, concurrency, reliability, and maintainability when inspecting Python backend and SQL-based database code, and is categorized under Software Engineering Fundamentals.

  • hard
  • Salesforce
  • Software Engineering Fundamentals
  • Software Engineer

How do you perform a thorough code review?

Company: Salesforce

Role: Software Engineer

Category: Software Engineering Fundamentals

Difficulty: hard

Interview Round: Take-home Project

You are given several Python backend files to review (treat this as an “OA in code-review format”). The code performs database operations such as SQL INSERTs and SELECT queries. Your task: 1) Write at least 10 code-review comments, each focusing on a different area (security, correctness, data modeling, concurrency, reliability, maintainability, etc.). 2) Identify likely issues such as: - Hard-coded secrets/credentials - Problems in the SQL schema/design - Race conditions or missing transactional safeguards 3) For each issue you raise, propose a concrete fix or improvement (code change, schema change, configuration change, or testing/monitoring addition). Assume you cannot run the code; you must review it from reading only.

Quick Answer: This task evaluates a candidate's code-review proficiency across security, correctness, data modeling, concurrency, reliability, and maintainability when inspecting Python backend and SQL-based database code, and is categorized under Software Engineering Fundamentals.

Related Interview Questions

  • Choose DynamoDB vs MySQL for a backend - Salesforce (medium)
  • Write SQL for top spender and non-spenders - Salesforce (medium)
  • Design an Elevator Control System - Salesforce (easy)
Salesforce logo
Salesforce
Feb 17, 2026, 12:00 AM
Software Engineer
Take-home Project
Software Engineering Fundamentals
6
0

You are given several Python backend files to review (treat this as an “OA in code-review format”). The code performs database operations such as SQL INSERTs and SELECT queries.

Your task:

  1. Write at least 10 code-review comments, each focusing on a different area (security, correctness, data modeling, concurrency, reliability, maintainability, etc.).
  2. Identify likely issues such as:
    • Hard-coded secrets/credentials
    • Problems in the SQL schema/design
    • Race conditions or missing transactional safeguards
  3. For each issue you raise, propose a concrete fix or improvement (code change, schema change, configuration change, or testing/monitoring addition).

Assume you cannot run the code; you must review it from reading only.

Solution

Show

Submit Your Answer to Earn 20XP

Sign in to leave a comment

Loading comments...

Browse More Questions

More Software Engineering Fundamentals•More Salesforce•More Software Engineer•Salesforce Software Engineer•Salesforce Software Engineering Fundamentals•Software Engineer Software Engineering Fundamentals
PracHub

Master your tech interviews with 8,000+ real questions from top companies.

Product

  • Questions
  • Learning Tracks
  • Interview Guides
  • Resources
  • Premium
  • For Universities
  • Student Access

Browse

  • By Company
  • By Role
  • By Category
  • Topic Hubs
  • SQL Questions
  • Compare Platforms
  • Discord Community

Support

  • support@prachub.com
  • (916) 541-4762

Legal

  • Privacy Policy
  • Terms of Service
  • About Us

© 2026 PracHub. All rights reserved.