How would you run a mentoring-focused code review?
Company: Disney
Role: Software Engineer
Category: Software Engineering Fundamentals
Difficulty: easy
Interview Round: Onsite
## Scenario
You’re given a **poorly written frontend code change** (e.g., a React/TypeScript component + related state and API calls) authored by a junior engineer. The code “works” but is hard to maintain.
## Task
Conduct a code review and explain:
1. **What issues you would point out**, prioritized by impact (correctness, security, performance, accessibility, maintainability).
2. **How you would communicate feedback** so the junior engineer learns (tone, framing, asking questions vs. prescribing).
3. **What concrete refactors you would suggest** (component structure, state management, separation of concerns, naming, typing, error handling).
4. **What tests you would add or request** (unit, integration, UI/e2e) and what behaviors they should cover.
5. **How you’d follow up** after the review (pairing, docs, conventions, future prevention).
Assume you can ask clarifying questions about requirements and constraints.
Overview: This question evaluates mentoring-focused code review competencies, including code quality and maintainability analysis, frontend architecture (React/TypeScript), testing strategy, accessibility and security awareness, plus written and interpersonal feedback skills.
Read the full Disney Software Engineer interview experience this question came from